SF-3622 Definitively associate draft generation metrics #3521
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #3521 +/- ##
==========================================
+ Coverage 82.47% 82.48% +0.01%
==========================================
Files 615 615
Lines 36935 37009 +74
Branches 6014 6031 +17
==========================================
+ Hits 30463 30528 +65
Misses 5585 5585
- Partials 887 896 +9 ☔ View full report in Codecov by Sentry. |
marksvc
changed the title
There was a problem hiding this comment.
Pull Request Overview
This PR implements tracking of draft generation requests across related NMT drafting events by adding a draftGenerationRequestId tag. This SF-specific identifier is generated at the start of pre-translation builds and propagated through the system using Activity.Current.Tags, method parameters, and event metric lookups.
Key Changes:
- Added
Tagsfield toEventMetricmodel to store Activity tags - Modified
EventMetricServiceto collect and save tags from Activity chain (child overrides parent) - Updated
MachineProjectServiceandMachineApiServiceto propagatedraftGenerationRequestIdthrough method signatures and Activity tags - For SMT builds,
nullis passed fordraftGenerationRequestId
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
EventMetric.cs |
Added Tags dictionary property to store Activity metadata |
event-metric.ts |
Added optional tags field to TypeScript interface |
EventMetricService.cs |
Implemented Activity tag collection from parent/child chain with child override logic |
EventMetricLogger.cs |
Created Activity instances to enable tag propagation through intercepted methods |
MachineApiService.cs |
Generated draftGenerationRequestId for NMT builds and looked up IDs from BuildProjectAsync events |
MachineProjectService.cs |
Added draftGenerationRequestId parameter and Activity tag setting for build methods |
IMachineProjectService.cs |
Updated interface signature with new optional parameter |
SyncService.cs |
Passed null for draftGenerationRequestId when triggering SMT builds |
EventMetricServiceTests.cs |
Added tests for Activity tag collection and parent/child override behavior |
MachineProjectServiceTests.cs |
Updated all test calls with draftGenerationRequestId: null and added Activity tag verification test |
MachineApiServiceTests.cs |
Added mocks for GetDraftGenerationRequestIdForBuildAsync and tests for tag propagation |
test/SIL.XForge.Scripture.Tests/Services/MachineApiServiceTests.cs
Outdated
Show resolved
Hide resolved
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
test/SIL.XForge.Scripture.Tests/Services/MachineApiServiceTests.cs
Outdated
Show resolved
Hide resolved
test/SIL.XForge.Scripture.Tests/Services/MachineApiServiceTests.cs
Outdated
Show resolved
Hide resolved
marksvc
changed the title
Records SF request id to help find related events. Drafting event metrics that are associated with the same NMT draft generation request have a 'tags.draftGenerationRequestId' written to them with an SF-specific id. This id is transferred around by Activity.Current.Tags, by method arguments, and looked up by finding a BuildProjectAsync event with a Serval build id. When SMT is used, `null` is passed for draftGenerationRequestId method arguments.
|
This is on pause so I can learn more about its usage on the frontend. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Records SF request id to help find related events.
Drafting event metrics that are associated with the same NMT draft
generation request have a 'tags.draftGenerationRequestId' written to
them with an SF-specific id. This id is transferred around by
Activity.Current.Tags, by method arguments, and looked up by finding a
BuildProjectAsync event with a Serval build id.
When SMT is used,
nullis passed for draftGenerationRequestId methodarguments.
This change is